Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BP Votes Tab to Account Page #803

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add BP Votes Tab to Account Page #803

merged 2 commits into from
Nov 24, 2023

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented Nov 12, 2023 •
edited
Loading

Fixes #751

Description

Add a tab on the Account page that shows the BPs that the user has voted for.

Test scenarios

Go to account page and click on "Votes" tab.

hmXs9tP.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

✅ Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 809bf48
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/656111d498492d00082d3a16
😎 Deploy Preview https://deploy-preview-803--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

✅ Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 809bf48
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/656111d4b32c6a000777a87a
😎 Deploy Preview https://deploy-preview-803--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kylanhurt kylanhurt changed the title 751 bp votes Add BP Votes Tab to Account Page Nov 12, 2023
@kylanhurt
Initial implementation of BP votes tab
7cfa21c 
Change BP Vote css to scss

Improve styling for BP Vote tab

Remove progress graph for BP Votes, adjust syntax
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 809bf48
Status: ✅  Deploy successful!
Preview URL: https://403182ee.open-block-explorer.pages.dev
Branch Preview URL: https://751-bp-votes.open-block-explorer.pages.dev

View logs

@donnyquixotic donnyquixotic merged commit 1c2821c into develop Nov 24, 2023
10 checks passed
@donnyquixotic donnyquixotic deleted the 751-bp-votes branch November 24, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnyquixotic donnyquixotic donnyquixotic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylanhurt @donnyquixotic